Initialize geometry fields for torus grids #853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few torus tests, as well as tests that are expected to fail.
Avoid conflict with gt4py GridType.
Make accessing geometry_type easier from GlobalGridParams, when grid_params is None (user does not have to check if the nested grid_params is None to access grid_params.geometry_type).
Will be refactored later.
It provides little value over the regular constructor. The regular constructor now takes keywords, so passing just the mean_cell_area by keyword is simpler and clearer.
msimberg
changed the title
msimberg
commented
Nov 14, 2025
| { | ||
| "coriolis_parameter": gtx.as_field( | ||
| (dims.EdgeDim,), | ||
| self._xp.zeros( |
Contributor
Author
There was a problem hiding this comment.
This should be a constant, set from configuration.
Contributor
Author
|
I'm going to start splitting this into separate PRs, with the help of @jcanton:
I'll keep this PR open for integration testing of different branches, but the other PRs should be what gets merged. |
msimberg
force-pushed
the
better-torus-support-4
branch
from
7e8ee34 to
e327091
Compare
msimberg
force-pushed
the
better-torus-support-4
branch
from
e327091 to
f49e3c7
Compare
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Contributor
Author
Contributor
Author
|
This is replaced by #965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4 of N for better torus support. This is on top of #848.
Nothing to see here yet, only opening for more thorough testing in CI.
This is the first PR that actually tries to read torus grid files and set up geometries correctly. Tests with torus grids (specifically, the Weisman Klemp experiment) added for anything that uses the generic
experimentfixture. A few fields are not available in serialized data and tests for those are skipped.