Enable testing for py310 py311 and py313 in CI #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
fix-python-ver
branch
from
55d1298 to
87c4ae4
Compare
agoscinski
commented
Jul 3, 2025
.github/workflows/ci.yaml
Outdated
| strategy: | ||
| matrix: | ||
| python-version: ['3.10', '3.11', '3.12', '3.13'] | ||
| python-version: ['3.11'] |
Collaborator
Author
There was a problem hiding this comment.
this should be reverted
GeigerJ2
reviewed
Jul 3, 2025
pyproject.toml
Outdated
| [tool.hatch.envs.default] | ||
| installer = "uv" | ||
| python = "3.12" | ||
| python = "python" |
Collaborator
There was a problem hiding this comment.
Fix this to something static. 3.10 ? 3.12 ?
Collaborator
Author
There was a problem hiding this comment.
we agreed to use py3.12
agoscinski
commented
Jul 3, 2025
agoscinski
commented
Jul 17, 2025
agoscinski
commented
Jul 17, 2025
agoscinski
commented
Jul 17, 2025
agoscinski
commented
Jul 17, 2025
agoscinski
force-pushed
the
fix-python-ver
branch
from
3e976bf to
624ca89
Compare
Due to the hatch setup the tests in the CI only ran on py312. It seems that hatch python discoverability detected a py312 version on the runner and therefore always defaulted to py312. It is needed to add to the python version to the test matrix to support the other python versions for running with hatch test.
agoscinski
force-pushed
the
fix-python-ver
branch
from
624ca89 to
ff73dc0
Compare
agoscinski
force-pushed
the
fix-python-ver
branch
from
ff73dc0 to
828038c
Compare
agoscinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code fails for <py3.12. Somehow hatch runs on different python version. I don't know where it finds executable from. But see the CI from latest run on main for py3.11
I needed to add to the test matrix more versions and changed the default to use system python version. The fixes that need to be done in the code are marginal.