Skip to content

Update ArrayBasedUnicodeEscaper.java #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VacancyIF wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ArrayBasedUnicodeEscaper.java #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/main/java/com/google/common/escape/ArrayBasedUnicodeEscaper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,30 @@
package com.google.common.escape;

public abstract class ArrayBasedUnicodeEscaper {
// The first code point in the safe range.
/*The first code point in the safe range.*/
private int safeMin;
// The last code point in the safe range.
/*The last code point in the safe range.*/
private int safeMax;

private char safeMinChar;
private char safeMaxChar;

protected ArrayBasedUnicodeEscaper() {
// This is a bit of a hack but lets us do quicker per-character checks in
// the fast path code. The safe min/max values are very unlikely to extend
// into the range of surrogate characters, but if they do we must not test
// any values in that range. To see why, consider the case where:
// safeMin <= {hi,lo} <= safeMax
// where {hi,lo} are characters forming a surrogate pair such that:
// codePointOf(hi, lo) > safeMax
// which would result in the surrogate pair being (wrongly) considered safe.
// If we clip the safe range used during the per-character tests so it is
// below the values of characters in surrogate pairs, this cannot occur.
// This approach does mean that we break out of the fast path code in cases
// where we don't strictly need to, but this situation will almost never
// occur in practice.
/*
This is a bit of a hack but lets us do quicker per-character checks in
the fast path code. The safe min/max values are very unlikely to extend
into the range of surrogate characters, but if they do we must not test
any values in that range. To see why, consider the case where:
safeMin <= {hi,lo} <= safeMax
where {hi,lo} are characters forming a surrogate pair such that:
codePointOf(hi, lo) > safeMax
which would result in the surrogate pair being (wrongly) considered safe.
If we clip the safe range used during the per-character tests so it is
below the values of characters in surrogate pairs, this cannot occur.
This approach does mean that we break out of the fast path code in cases
where we don't strictly need to, but this situation will almost never
occur in practice.
*/
if (safeMin >= Character.MIN_HIGH_SURROGATE) {
this.safeMinChar = Character.MAX_VALUE;
this.safeMaxChar = 0;
Expand Down