Skip to content

Conversation

@saimeunt
Copy link
Contributor

@saimeunt saimeunt commented Nov 29, 2024

Closes #94

This PR implements unit tests for the tournament_system.
complete_tournament function has been implemented with a basic approach that simply changes the status for now.

.tool-versions has been added for automatically switching to the appropriate version of the tools used (scarb & dojo) when using https://asdf-vm.com/.

Summary by CodeRabbit

  • New Features

    • Introduced new tools for project management: scarb 2.7.0 and dojo 1.0.0-alpha.5.
    • Added a dedicated module for tournament testing, enhancing testing capabilities.
    • Implemented a new method to complete tournaments, updating their status.
  • Bug Fixes

    • Updated tournament structure to use player IDs instead of player objects, improving data handling.
  • Tests

    • Added a comprehensive suite of unit tests for tournament functionalities, covering various scenarios and edge cases.

@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2024

Walkthrough

This pull request introduces changes across several files to enhance the tournament management system. The .tool-versions file is updated to include the versions for scarb (2.7.0) and dojo (1.0.0-alpha.5), ensuring consistent tool usage in the development environment. A new testing module named test_tournament is added to src/lib.cairo, expanding the testing capabilities for tournament functionalities. The Tournament struct in src/models/tournament.cairo is modified to change the current_participants field from an array of Player objects to an array of u32 player IDs. Corresponding changes are made in the src/systems/tournament.cairo file, where method signatures are updated to reflect this shift in data representation. Additionally, a new method complete_tournament is introduced in the ITournamentAction trait. Finally, a comprehensive suite of unit tests is included in src/tests/test_tournament.cairo, covering various aspects of tournament management, including creation, registration, and state transitions.

Possibly related issues

Possibly related PRs

Suggested labels

enhancement, ODHack10, M, actual: 2

Suggested reviewers

  • danielcdz
  • coxmars

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]

This comment was marked as spam.

@RolandoDrRobot
Copy link
Contributor

Hello @saimeunt 👋 could you please post a pic of the test passing? the sozo-test here is failing as well, thanks

@saimeunt
Copy link
Contributor Author

saimeunt commented Dec 2, 2024

Here's the screenshot of the tests passing (filtered out for tournament but they are all passing):

Screenshot 2024-12-02 at 08 48 48

I ran sozo build and committed the changes, maybe this will do the trick?

coderabbitai[bot]

This comment was marked as spam.

Copy link
Contributor

@danielcdz danielcdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for all the refactor and improvements @saimeunt

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work on this! LGTM ✅

@coxmars coxmars merged commit 194c3c8 into ByteBeasts:main Dec 3, 2024
1 check passed
coxmars pushed a commit that referenced this pull request Dec 3, 2024
* Dependencies and leaderboardEntry class

* leaderboard behavior

* dynamycally update entry

* deleted unnecessary comments

* switched Alexandria to 2.6.0 and add good methods

* remove entry test

* removed an unnecessary dependency

* getter functions and necessary tests with negative scenarious as well

* timestamp update in remove_entry function

* typo

* score calculation

* manifests

* refactor and rename fn upgrade_entry_stats  and add   negative test. Leaderboard's test file moved to test directory.

* Add tests for tournament_system (#101)

* Add tests for tournament_system

* Quickfixes

* sozo build

* SeasonModel & Tests (#103)

* branch

* sozo build

* refactor and rename fn upgrade_entry_stats  and add   negative test. Leaderboard's test file moved to test directory.

---------

Co-authored-by: saimeunt <saimeunt@gmail.com>
Co-authored-by: Bosun <96661657+Bosun-Josh121@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement unit tests for the tournament PoC model

4 participants