-
Notifications
You must be signed in to change notification settings - Fork 19
Add tests for tournament_system #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request introduces changes across several files to enhance the tournament management system. The Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hello @saimeunt 👋 could you please post a pic of the test passing? the sozo-test here is failing as well, thanks |
danielcdz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for all the refactor and improvements @saimeunt
coxmars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work on this! LGTM ✅
* Dependencies and leaderboardEntry class * leaderboard behavior * dynamycally update entry * deleted unnecessary comments * switched Alexandria to 2.6.0 and add good methods * remove entry test * removed an unnecessary dependency * getter functions and necessary tests with negative scenarious as well * timestamp update in remove_entry function * typo * score calculation * manifests * refactor and rename fn upgrade_entry_stats and add negative test. Leaderboard's test file moved to test directory. * Add tests for tournament_system (#101) * Add tests for tournament_system * Quickfixes * sozo build * SeasonModel & Tests (#103) * branch * sozo build * refactor and rename fn upgrade_entry_stats and add negative test. Leaderboard's test file moved to test directory. --------- Co-authored-by: saimeunt <saimeunt@gmail.com> Co-authored-by: Bosun <96661657+Bosun-Josh121@users.noreply.github.com>

Closes #94
This PR implements unit tests for the tournament_system.
complete_tournamentfunction has been implemented with a basic approach that simply changes the status for now..tool-versionshas been added for automatically switching to the appropriate version of the tools used (scarb & dojo) when using https://asdf-vm.com/.Summary by CodeRabbit
New Features
scarb 2.7.0anddojo 1.0.0-alpha.5.Bug Fixes
Tests