Skip to content

fix: founder allocation init values bug#855

Merged
dan13ram merged 1 commit intostagingfrom
fix/dao-creation-founder-bug
Feb 11, 2026
Merged

fix: founder allocation init values bug#855
dan13ram merged 1 commit intostagingfrom
fix/dao-creation-founder-bug

Conversation

@dan13ram
Copy link
Collaborator

@dan13ram dan13ram commented Feb 11, 2026

Summary by CodeRabbit

  • New Features
    • The founder allocation form now initializes fields when starting a new allocation: allocation percentage defaults to 0% and the end date defaults to one month from today.
    • For new founder entries with no prior allocations, fields no longer appear blank on first load, providing immediate, ready-to-edit values for faster setup.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
testnet-nouns-builder Building Building Preview Feb 11, 2026 3:22pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
nouns-builder Ignored Ignored Feb 11, 2026 3:22pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Default founder allocation initialization updated: allocationPercentage now 0 and endDate set via getOneMonthFromNow() when no existing allocations; minor formatting cleanup.

Changes

Cohort / File(s) Summary
Allocation form defaults
packages/create-dao-ui/src/components/AllocationForm/AllocationForm.tsx
Initialize new founder entries with allocationPercentage=0 and endDate=getOneMonthFromNow() instead of empty strings; minor formatting adjustment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

A nibble of code, a carrot of time,
I set defaults neat, proportions sublime.
Zero to start, a month on the clock—
Hop to the future with a gentle knock.
In fields of forms, I thump with glee,
“Initialized!” squeaks this happy bunny 🥕

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dao-creation-founder-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dan13ram dan13ram merged commit cccde7c into staging Feb 11, 2026
2 of 4 checks passed
@dan13ram dan13ram deleted the fix/dao-creation-founder-bug branch February 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant