-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 9 vulnerabilities #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| aiohttp==3.8.4 | ||
| aiohttp==3.13.3 | ||
| aiosignal==1.3.1 | ||
| async-timeout==4.0.2 | ||
| attrs==23.1.0 | ||
|
|
@@ -28,5 +28,5 @@ tenacity==8.2.2 | |
| tqdm==4.65.0 | ||
| typing-inspect==0.8.0 | ||
| typing_extensions==4.5.0 | ||
| urllib3==1.26.15 | ||
| urllib3==2.6.3 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The updated pin Useful? React with 👍 / 👎. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incompatible requests and urllib3 version combinationHigh Severity Upgrading 🔬 Verification TestWhy verification test was not possible: This is a known dependency compatibility issue documented in GitHub issue psf/requests#6432 ("The latest version of requests (2.29.0) does not support urllib3 2.0.0"). The PR description's warning message explicitly confirms the conflict. Testing would require installing both packages together and attempting to make HTTP requests, which would fail at import time or when making requests. Additional Locations (1) |
||
| yarl==1.9.2 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency version conflict between aiohttp and its dependencies
High Severity
Upgrading
aiohttpfrom 3.8.4 to 3.13.3 is a significant major version jump that requires compatible versions of its dependencies. Therequirements.txtstill pinsyarl==1.9.2,frozenlist==1.3.3,multidict==6.0.4, andaiosignal==1.3.1, which are likely incompatible withaiohttp==3.13.3. This will cause pip to fail resolving dependencies or produce runtime errors. Whenaiohttpis upgraded, its peer dependencies also need to be upgraded to compatible versions.🔬 Verification Test
Why verification test was not possible: This is a dependency version conflict issue that would manifest during
pip install -r requirements.txt. The PR description's warning ("requests 2.29.0 requires urllib3, which is not installed") confirms pip resolver issues. Verifying this would require running pip install in an isolated environment, which would fail due to conflicting version constraints betweenaiohttp==3.13.3and the pinned older versions ofyarl,frozenlist,multidict, andaiosignal.Additional Locations (2)
examples/langchain/langchainpy-localai-example/requirements.txt#L9-L10examples/langchain/langchainpy-localai-example/requirements.txt#L31-L32