[BREAKING] Drop support for Node <6.6.0 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I have one doubt with only using the native timing method: performance. The benchmark tests return a bad performance for the native method using Buffer.alloc and a even worse performance using Buffer.allocUnsafe. Therefore I have to validate the benchmark itself first and then decide on how to continue here. Any comments on that @Drexonom ? |
Contributor
Author
|
How can I see the benchmark results? |
Owner
|
Matcha in Posttest ist broken for newer Node.js versions. I just tested it with some different performance testing libraries. Maybe I can upload an example soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the package tiny and dependency-free by removing ponyfills needed only by EOL Node.js.
#13 should be released first as 1.1.5.