Update and Fix a few of the issues#7
Open
caemor wants to merge 24 commits intoBroderickCarlin:masterfrom
Open
Conversation
- Split up files - Add Parameters (unfinished) for lang and units (metric,...) - Switch to edition 2018 - add Settings/Parameters to each function
- add cnt to weather report5day - fix timeslicehourly with optional rain and snow - add snow - fix cityshort with newly needed/included parameters (population, timezone, sunrise, sunset)
- make Wind:deg optional - add WeatherReportCurrent::timezone
Rain and Snow structs were already defined but were not yet included in the WeatherReportCurrent struct, although they do occur in the JSON response from OpenWeatherMaps.
Add 'rain' and 'snow' to struct WeatherReportCurrent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seems to be similar to Palindromes PR with fixing a few of the issues, but based on simeonschaubs updates and therefore it is slightly different.
Fixes #3, #4
What this adds/changes:
What is still missing: