Skip to content

fix: Update to eslint9 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GZolla merged 2 commits into from
Nov 25, 2024
Merged

fix: Update to eslint9 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48115c6
fix: Update to eslint9
GZolla Nov 5, 2024
66a23d9
Use updated shared configs
GZolla Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Copy link
Contributor Author

@GZolla GZolla Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since "type":"module" is not set in package.json then the .mjs extension is needed.

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { litConfig, setDirectoryConfigs, testingConfig } from 'eslint-config-brightspace';
export default setDirectoryConfigs(
litConfig,
{
test: testingConfig
}
);
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"devDependencies": {
"@babel/core": "^7",
"@brightspace-ui/testing": "^1",
"eslint": "^8",
"eslint-config-brightspace": "^1.0",
"eslint": "^9",
"eslint-config-brightspace": "^2",
"sinon": "^19"
}
}
3 changes: 0 additions & 3 deletions test/.eslintrc.json
View file
Open in desktop

This file was deleted.