Skip to content

fix: make loading-spinner divisible by 6px #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GZolla wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: make loading-spinner divisible by 6px #6508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9eb26e
fix: make loading-spinner divisible by 6
GZolla Jan 15, 2026
ef8153b
Iron out
GZolla Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions components/loading-spinner/loading-spinner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ class LoadingSpinner extends LitElement {
}

.d2l-loading-spinner-wrapper {
height: var(--d2l-loading-spinner-size, 50px);
height: var(--d2l-loading-spinner-size, 48px);
margin: auto;
overflow: hidden;
position: relative;
width: var(--d2l-loading-spinner-size, 50px);
width: var(--d2l-loading-spinner-size, 48px);
}
svg {
background: radial-gradient(rgba(0, 0, 0, 0.1), transparent 70%); /* 70% ≈ 100%/sqrt(2) = radius of circle since corners lie on 100% of radial gradient */
Expand All @@ -63,7 +63,7 @@ class LoadingSpinner extends LitElement {
.inner-circle {
fill: none;
stroke: var(--d2l-loading-spinner-color, var(--d2l-color-celestine));
stroke-width: 2;
stroke-width: 3;
}

.slice {
Expand Down Expand Up @@ -119,11 +119,11 @@ class LoadingSpinner extends LitElement {
render() {
return html`
<div class="d2l-loading-spinner-wrapper">
<svg viewBox="0 0 50 50" fill-rule="evenodd">
<svg viewBox="0 0 48 48" fill-rule="evenodd">
<g>
<circle cx="25" cy="25" r="19" class="outer-circle-stroke"></circle>
<circle cx="25" cy="25" r="19" class="outer-circle"></circle>
<circle cx="25" cy="25" r="13" class="inner-circle"></circle>
<circle cx="24" cy="24" r="21" class="outer-circle-stroke"></circle>
<circle cx="24" cy="24" r="21" class="outer-circle"></circle>
<circle cx="24" cy="24" r="13.5" class="inner-circle"></circle>
</g>
${Array.from({ length: 5 }).map((_, i) => this.#renderSlice(i + 1))}
</svg>
Expand All @@ -147,8 +147,8 @@ class LoadingSpinner extends LitElement {
};
classes[`slice-${index}`] = true;
return svg`<g class="${classMap(classes)}">
<path d="M39 25h5a19 19 0 0 0 -19 -19v5a 1 1 0 0 1 0 2v12h12a1 1 0 0 1 2 0z" fill="#FFF"></path>
<path d="M25 13a1 1 0 0 0 0 -2a14 14 0 0 1 14 14a1 1 0 0 0 -2 0a12 12 0 0 0 -12 -12z" fill="#E6EAF0"></path>
<path d="M39 24h6a21 21 0 0 0 -21 -21v6a 1.5 1.5 0 0 1 0 3v12h12a1.5 1.5 0 0 1 3 0z" fill="#FFF"></path>
<path d="M39 24a15 15 0 0 0 -15 -15a1.5 1.5 0 0 1 0 3a12 12 0 0 1 12 12a1.5 1.5 0 0 1 3 0z" fill="#E6EAF0"></path>
</g>`;
}

Expand Down
Loading