Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't worked on BOML in a sec, but TOML 1.1 got released and this seems like a good chance to cleanup/update code while also adding support for the new TOML 1.1 features.
As of writing BOML passes all the new TOML 1.1 valid tests. It's still failing some invalid tests, but honestly I'm not sure if I want to pass some of these - some are from invalid characters in comments, which is just annoying to parse and also slows BOML down. Maybe I can put it behind a
pedanticfeature flag or something.Anyways, I've developed new skills since I've last worked on BOML, so in addition to supporting TOML 1.1 I'd like to clean up and improve my old code. Will probably read over the code a couple more times, add more internal docs, then see if there's any invalid TOML tests that'll be easy to address and fix those before merging this.