ArtNet-Server: use jspack to unpack the UDP Datagram #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpack UDP Datagram
The newest version of this module in npm is 0.1.0 where it seems that #7 has not been included so I started to fix this myself as well.
Nevertheless, I feel that the use of
jspackis a more robust solution than the previous fix.Moreover, I was wondering if the Header should be checked and only be deserialised if everything is correct. Hence the todo in the code.
Also, I hav added a
.gitignoreto exclude the dependencies that are installed by npm and also to exclude some typical Windows and OSX files.