even, odd #66
Open
even, odd #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 2, 2025
Learn more in the Cursor dashboard.
| n += if f >= 0.0 { 1.0 } else { -1.0 }; | ||
| } | ||
| Ok(n) | ||
| }); |
There was a problem hiding this comment.
Bug: Floating Point to Integer Overflow in Modulo Functions
The EVEN and ODD functions can panic or produce incorrect results due to unsafe f64 to i64 casting for modulo operations. For very large negative numbers (including negative infinity), (n as i64).abs() can overflow, causing a panic in debug mode. For very large positive numbers exceeding i64::MAX, the f64 to i64 cast itself overflows, leading to undefined behavior and incorrect modulo calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test --no-fail-fast --quiethttps://chatgpt.com/codex/tasks/task_e_688a6d7a13388327ae536d837aa9750f