Skip to content

COUPDAYBS, COUPDAYS, COUPDAYSNC, COUPNCD, COUPNUM, COUPPCD #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrianHung wants to merge 3 commits into from
Closed

COUPDAYBS, COUPDAYS, COUPDAYSNC, COUPNCD, COUPNUM, COUPPCD #59

BrianHung wants to merge 3 commits into from

Conversation

@BrianHung
Copy link
Owner

@BrianHung BrianHung commented Jul 31, 2025

Summary

  • implement coupon-related financial functions (COUPDAYBS, COUPDAYS, COUPDAYSNC, COUPNCD, COUPNUM, COUPPCD)
  • support day count calculations and coupon date logic
  • extend static analysis and function registry for new functions
  • document new functions as available
  • add unit tests covering the new functions

Testing

  • cargo test -p ironcalc_base

https://chatgpt.com/codex/tasks/task_e_688a70ad5d9c8327aa1b1a8c9ae3ff73

@BrianHung BrianHung changed the title Implement coupon financial functions COUPDAYBS, COUPDAYS, COUPDAYSNC, COUPNCD, COUPNUM, COUPPCD Jul 31, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung
Copy link
Owner Author

BrianHung commented Jul 31, 2025

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]
cursor bot reviewed Jul 31, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

@BrianHung BrianHung added the ready to merge PRs ready to merge label Jul 31, 2025
BrianHung added a commit that referenced this pull request Jul 31, 2025
@BrianHung
merge coupdaybs, coupdays, coupdaysnc, coupncd, coupnum, couppcd #59
984f1aa
@BrianHung
Copy link
Owner Author

BrianHung commented Jul 31, 2025

Consolidating and closing in favor of #54.

@BrianHung BrianHung closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

codex ready to merge PRs ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrianHung