Skip to content

gcd, lcm #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrianHung wants to merge 6 commits into from
Closed

gcd, lcm #39

BrianHung wants to merge 6 commits into from

Conversation

@BrianHung
Copy link
Owner

@BrianHung BrianHung commented Jul 14, 2025

Summary

  • implement GCD and LCM in the math functions
  • wire new functions in function dispatch and static analysis
  • add basic tests for GCD and LCM

Testing

  • cargo test

https://chatgpt.com/codex/tasks/task_e_6874b7a1b77c8327978e6113fa66a4e6

@BrianHung BrianHung changed the title Implement GCD and LCM functions gcd, lcm Jul 14, 2025
BrianHung
BrianHung commented Jul 19, 2025
View reviewed changes
base/src/test/test_gcd.rs
use crate::test::util::new_empty_model;

#[test]
fn test_fn_gcd_arguments() {
Copy link
Owner Author

@BrianHung BrianHung Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more comprehensive tests.

@BrianHung
Copy link
Owner Author

BrianHung commented Jul 19, 2025

@cursor come up with more comprehensive tsts for gcm lcm

@BrianHung
Copy link
Owner Author

BrianHung commented Jul 19, 2025

cursor review

cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung
Copy link
Owner Author

BrianHung commented Jul 20, 2025

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung
Copy link
Owner Author

BrianHung commented Jul 20, 2025

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]
cursor bot reviewed Jul 20, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!

Was this report helpful? Give feedback by reacting with 👍 or 👎

@BrianHung BrianHung added the ready to merge PRs ready to merge label Jul 20, 2025
BrianHung added a commit that referenced this pull request Jul 30, 2025
@BrianHung
merge gcd, lcm #39
b2638b5
@BrianHung
Copy link
Owner Author

BrianHung commented Jul 30, 2025

Consolidating and close in favor of #52.

@BrianHung BrianHung closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

codex ready to merge PRs ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrianHung