Skip to content

Conversation

@BrianHung
Copy link
Owner

Summary

  • implement SUMPRODUCT function
  • enable SUMIF and SUMIFS in docs
  • add tests for SUMIF and SUMPRODUCT

Testing

  • cargo test --workspace --lib

https://chatgpt.com/codex/tasks/task_e_68657274956c83279330f179fe5fc4aa

@BrianHung BrianHung changed the title Implement SUMIF/SUMIFS/SUMPRODUCT sumif, sumifs, sumproduct Jul 14, 2025
@BrianHung
Copy link
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

@BrianHung
Copy link
Owner Author

Should be its own PR.

@BrianHung
Copy link
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

@BrianHung
Copy link
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

@BrianHung BrianHung added the ready to merge PRs ready to merge label Jul 22, 2025
@BrianHung
Copy link
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub (page stubs do not have to be created in this commit or PR they just have to exist :))

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Function Documentation Pages

The documentation marks SUMIF and SUMIFS as 'Available' with links to their documentation pages (SUMIF and SUMIFS). However, these linked page stubs are not visible in the provided diff, indicating they may not exist. This violates the requirement that functions must be 'properly documented with their own page stub' that 'just have to exist' to prevent 404 errors, unlike SUMPRODUCT which had its page updated.

docs/src/functions/math-and-trigonometry.md#L85-L88

| SUM | <Badge type="tip" text="Available" /> ||
| SUMIF | <Badge type="tip" text="Available" /> | [SUMIF](math_and_trigonometry/sumif) |
| SUMIFS | <Badge type="tip" text="Available" /> | [SUMIFS](math_and_trigonometry/sumifs) |
| SUMPRODUCT | <Badge type="tip" text="Available" /> | [SUMPRODUCT](math_and_trigonometry/sumproduct) |

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex ready to merge PRs ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants