-
Notifications
You must be signed in to change notification settings - Fork 0
insert delete rows cols #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cursor review |
|
cursor review can you find any other bugs with our implementation of this feature; would you make any improvements before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Empty Row Deletion Fails
The delete_rows method fails when attempting to delete empty rows (rows with no data), returning the error "Row number '{r}' is not valid." This occurs because the method incorrectly validates row existence by checking for cell data in worksheet.sheet_data, which is absent for empty rows. This prevents users from deleting empty rows or ranges that include them. The method should allow deletion of any valid row index, treating empty rows as valid and collecting an empty HashMap for their old_data in the diff.
base/src/user_model/common.rs#L926-L930
IronCalc/base/src/user_model/common.rs
Lines 926 to 930 in c8775b2
| } | |
| let data = match worksheet.sheet_data.get(&r) { | |
| Some(s) => s.clone(), | |
| None => return Err(format!("Row number '{r}' is not valid.")), | |
| }; |
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
cursor review can you find any other bugs with our implementation of this feature; would you make any improvements before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
3fffcd9 to
55810ad
Compare
No description provided.