Skip to content

Conversation

@cmatKhan
Copy link
Member

@cmatKhan cmatKhan commented Sep 5, 2025

No description provided.

@cmatKhan cmatKhan requested review from MackLiao and Copilot September 5, 2025 13:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds filter parameters to API classes and updates dependencies to newer versions of numpy and pandas.

  • Adds new filter parameters "single_binding" and "composite_binding" to PromoterSetSigAPI and "source_name" to BindingAPI
  • Updates numpy dependency from "^1.20.3" to "^2.2.5"
  • Updates pandas dependency from "^1.5.3" to "^2.3.1"

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tfbpapi/PromoterSetSigAPI.py Replaces "binding" parameter with "single_binding" and "composite_binding"
tfbpapi/BindingAPI.py Adds "source_name" filter parameter
pyproject.toml Updates numpy and pandas versions to newer releases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cmatKhan
Copy link
Member Author

cmatKhan commented Sep 5, 2025

ignore the windows failure -- github removed windows 2019 support. i am just going to remove that test

Copy link
Collaborator

@MackLiao MackLiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we also need to update Django app to adapt these new filters?

@cmatKhan cmatKhan merged commit a7ced03 into BrentLab:dev Sep 8, 2025
10 of 12 checks passed
@cmatKhan cmatKhan deleted the add_params branch September 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants