Open
Conversation
You included docstrings in each function, which is good. There's no need to include them if your code self-comments and you have descriptive variable names. **Documentation: +1** Descriptive variable names and easy to follow code. Great job! **Style: +1** Code is pretty simple, but it works as intended. Make sure you're scrubbing out the articles like "a", "the", "or" etc, these affect your overall sentiment score. **Functionality: +3** Other comments: In the future, submit your writeup as a .pdf file. Delete unnecessary files from your repo, and put all the necessary images into the writeup. It makes your repo neater and more organized. Overall, nicely done! Your project is quite solid, and shows great understanding of how string manipulation works. **Grade: 5/5**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You included docstrings in each function, which is good. There's no need to include them if your code self-comments and you have descriptive variable names.
Documentation: +1
Descriptive variable names and easy to follow code. Great job!
Style: +1
Code is pretty simple, but it works as intended. Make sure you're scrubbing out the articles like "a", "the", "or" etc, these affect your overall sentiment score.
Functionality: +3
Other comments:
In the future, submit your writeup as a .pdf file. Delete unnecessary files from your repo, and put all the necessary images into the writeup. It makes your repo neater and more organized.
Overall, nicely done! Your project is quite solid, and shows great understanding of how string manipulation works.
Grade: 5/5