Open
Conversation
thepiwo
reviewed
Apr 6, 2019
Member
thepiwo
left a comment
thepiwo
left a comment
There was a problem hiding this comment.
shouldn't we update the data to not feature specific persons?
Member
Author
|
sounds good. Will do |
Member
|
This seems ok to me. Merge? @thepiwo @nerdsupremacist |
Member
|
I'd wait for adjustments regarding cleaning the data of specific persons |
Member
|
What exactly do you mean by that?
I don’t understand where personal information come from in this scenario.
… On 10. Apr 2019, at 21:37, Philipp Piwo ***@***.***> wrote:
I'd wait for adjustments regarding cleaning the data of specific persons
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#235 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHUOX0XS3KsCGz22fBvwpfnmWEs4hSapks5vfj1tgaJpZM4cUSQR>.
|
Member
|
The non-changed mock data creates specific users for Leo, Keno and David. I think it would be better to replace this with generic testing accounts and document the process on how his data can be used somewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.