Skip to content

spell haste #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alessandro-Barbieri wants to merge 7 commits into
base: master
Choose a base branch
from
Open

spell haste #390

Alessandro-Barbieri wants to merge 7 commits into from

Conversation

@Alessandro-Barbieri
Copy link
Contributor

@Alessandro-Barbieri Alessandro-Barbieri commented Dec 24, 2025 •
edited
Loading

@Alessandro-Barbieri Alessandro-Barbieri marked this pull request as ready for review December 25, 2025 16:18
BreakBB
BreakBB requested changes Jan 7, 2026
View reviewed changes
Copy link
Owner

@BreakBB BreakBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot: A migration is required for this to actually work.

The hasteRating and hasteBonus stats have a isTbcOnly = true in the Profile.lua. That needs to be removed there and in a proper migration as well (setting it to nil).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BreakBB BreakBB BreakBB requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alessandro-Barbieri @BreakBB