App settings #34
Closed
App settings #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts the implementation of an internal API for settings. Some design notes: 1. The settings are going to be POJOs, which are simple to understand, simple to write, and aren't obligated to have a setter 2. Key constants are listed in SettingKey. I'm not using the constants in `constants.xml` because a. It requires a `Context` dependency b. Some places of the code need the keys as strings
and implement an example (sync username)
and implement and example (reviewer frame style)
BrayanDSO
force-pushed
the
app-settings
branch
from
c4cf79c to
8fb64c0
Compare
and implement and example (answer button size) `preferences_accessibility` is being changed because the unit test showed that it was wrongly using `app:defaultValue`
and implement an example (enable dev options)
BrayanDSO
force-pushed
the
app-settings
branch
7 times, most recently
from
fa3b0d3 to
f910a6a
Compare
and implement some examples (Sync hkey and username)
BrayanDSO
force-pushed
the
app-settings
branch
3 times, most recently
from
744afee to
7ed16d5
Compare
they guarantee that the getter and the setter use the same key. Also, they reduce the boilerplate of writing a simple setter more delegates can be added later also made `username` nullable to make more obvious that the value wasn't set yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Supersedes ankidroid#12161 and ankidroid#8066
I'm open to opinions about the design. This is significantly simpler than ankidroid#12161 because I feel that it is overengineered, and 95%+ of our shared preferences usage is simply accessing a preference.
Fixes
Approach
In the commits.
The methods and settings are implemented incrementally to ease the reviewing process and to simplify the workflow.
How Has This Been Tested?
Unit tests + Manually checking if the changed settings still work
Learning (optional, can help others)
I haven't used much until now Java/Kotlin
mockmethods for tests. Probably there are better ways to do what I have done, but it was a nice learning experience.Also learned more about kotlin reflection
Checklist
Please, go through these checks before submitting the PR.