Skip to content

Added interfaces to allow for mocks in unit testing #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Scott-Lyons wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added interfaces to allow for mocks in unit testing #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d1dc1
Added interfaces to allow for mocks in unit testing
Apr 3, 2017
bdcf9d1
Moved IDisposable inheritance to ISimpleTcpClient
May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion SimpleTCP/Message.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,17 @@

namespace SimpleTCP
{
public class Message
public interface IMessage
{
byte[] Data { get; }
string MessageString { get; }
void Reply(byte[] data);
void Reply(string data);
void ReplyLine(string data);
TcpClient TcpClient { get; }
}

public class Message : IMessage
{
private TcpClient _tcpClient;
private System.Text.Encoding _encoder = null;
Expand Down
15 changes: 14 additions & 1 deletion SimpleTCP/SimpleTcpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,20 @@

namespace SimpleTCP
{
public class SimpleTcpClient : IDisposable
public interface ISimpleTcpClient : IDisposable
{
byte Delimiter { get; set; }
Encoding StringEncoder { get; set; }
bool AutoTrimStrings { get; set; }
SimpleTcpClient Connect(string hostNameOrIpAddress, int port);
SimpleTcpClient Disconnect();
TcpClient TcpClient { get; }
Copy link

@yarimiz yarimiz Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as .NET's TcpClient is not interfaced, ISimpleTcpClient won't help to mock Connected property.

void Write(byte[] data);
void Write(string data);
Message WriteLineAndGetReply(string data, TimeSpan timeout);
}

public class SimpleTcpClient : ISimpleTcpClient
{
public SimpleTcpClient()
{
Expand Down
23 changes: 22 additions & 1 deletion SimpleTCP/SimpleTcpServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,28 @@

namespace SimpleTCP
{
public class SimpleTcpServer
public interface ISimpleTcpServer
{
byte Delimiter { get; set; }
Encoding StringEncoder { get; set; }
bool AutoTrimStrings { get; set; }
event EventHandler<TcpClient> ClientConnected;
event EventHandler<TcpClient> ClientDisconnected;
event EventHandler<Message> DelimiterDataReceived;
event EventHandler<Message> DataReceived;
IEnumerable<IPAddress> GetIPAddresses();
List<IPAddress> GetListeningIPs();
void Broadcast(byte[] data);
void Broadcast(string data);
void BroadcastLine(string data);
SimpleTcpServer Start(int port, bool ignoreNicsWithOccupiedPorts = true);
SimpleTcpServer Start(int port, AddressFamily addressFamilyFilter);
SimpleTcpServer Start(IPAddress ipAddress, int port);
void Stop();
int ConnectedClientsCount { get; }
}

public class SimpleTcpServer : ISimpleTcpServer
{
public SimpleTcpServer()
{
Expand Down