DE-151249 PHPStan: PostConditionsTraitUsedRule: Skip non-test classes, add tests #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikkaluza
force-pushed
the
DE-151249-mockery-trait-rule-skip-non-test-classes
branch
from
5b11b90 to
5e33887
Compare
tomasJancar
approved these changes
Dec 19, 2025
dominik-vasicek
approved these changes
Jan 12, 2026
dominikkaluza
deleted the
DE-151249-mockery-trait-rule-skip-non-test-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockery trait usage is important only in test files. You may use a factory or some helper class to set up mocks, but those will ultimately be used in a test anyways. We don't need to enforce the trait on such factory/helper classes, it doesn't do anything.