DE-151249 Add TestsExtendMockeryTestCaseRule which enforces a Mockery base test case class #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikkaluza
changed the title
dominikkaluza
force-pushed
the
DE-151249-phpstan-mockery-test-case-rule
branch
from
edce304 to
f734784
Compare
dorrogeray
approved these changes
Dec 17, 2025
dominik-vasicek
approved these changes
Dec 17, 2025
.../TestsExtendMockeryTestCaseRule/__fixtures__/TestExtendsClassWhichExtendsMockeryTestCase.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockery recommends either the trait usage or the test case base class - https://docs.mockery.io/en/stable/reference/phpunit_integration.html#phpunit-integration.
In my opinion, the base class is safer and more reliable.
We've run into issues where the trait was missing even though we have a PHPStanrule for that, for example the expectation might be in some helper class which the current rule won't catch.
I'm not including the rule in
phpstan-extension.neonsince it causes too many errors on our current codebases, it's up to the consumer to include it in the configuration.