Skip to content

DE-151249 Make the PostConditionsTraitUsedRule non-ignorable #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dominikkaluza merged 2 commits into from
Dec 16, 2025
Merged

DE-151249 Make the PostConditionsTraitUsedRule non-ignorable #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b73207
Make the PostConditionsTraitUsedRule non-ignorable
dominikkaluza Dec 16, 2025
e20b540
Fix phpstan errors which are caused by newer phpstan version
dominikkaluza Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@ parameters:
- identifier: return.unusedType
paths:
- src/BrandEmbassyCodingStandard/Rector/MabeEnumClassToEnumRector/MabeEnumClassToEnumRector.php
- src/BrandEmbassyCodingStandard/Rector/NetteStringsStartsWithToNativeCallRector/NetteStringsStartsWithToNativeCallRector.php
- src/BrandEmbassyCodingStandard/Rector/NetteStringsEndsWithToNativeCallRector/NetteStringsEndsWithToNativeCallRector.php
- src/BrandEmbassyCodingStandard/Rector/MabeEnumMethodCallToEnumConstRector/MabeEnumMethodCallToEnumConstRector.php
- src/BrandEmbassyCodingStandard/Rector/MabeEnumClassToEnumRector/MabeEnumClassToEnumRectorTest.php
- src/BrandEmbassyCodingStandard/Rector/NetteStringsContainsToNativeCallRector/NetteStringsContainsToNativeCallRectorTest.php
- src/BrandEmbassyCodingStandard/Rector/MabeEnumMethodCallToEnumConstRector/MabeEnumMethodCallToEnumConstRectorTest.php
- # Because fixtures are in excludePaths, the constant won't be discovered by PHPStan
message: '#^Class BrandEmbassyCodingStandard\\PhpStan\\Rules\\DisallowConstantsInTestsRule\\__fixtures__\\AllowedConstant not found\.$#'
identifier: class.notFound
Expand Down
1 change: 1 addition & 0 deletions src/BrandEmbassyCodingStandard/PhpStan/Rules/Mockery/PostConditionsTraitUsedRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public function processNode(Node $node, Scope $scope): array
if (!$classReflection->hasTraitUse($traitName)) {
$errors[] = RuleErrorBuilder::message(sprintf('Calling %s without %s trait.', $name, $traitName))
->identifier('postConditions.noMockeryTrait')
->nonIgnorable()
->build();
}

Expand Down
3 changes: 3 additions & 0 deletions src/BrandEmbassyCodingStandard/Sniffs/Classes/TraitUseSpacingSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
use SlevomatCodingStandard\Helpers\PropertyHelper;
use SlevomatCodingStandard\Helpers\SniffSettingsHelper;
use SlevomatCodingStandard\Helpers\TokenHelper;
use function assert;
use function count;
use function is_int;
use function reset;
use function sprintf;
use function substr_count;
Expand Down Expand Up @@ -221,6 +223,7 @@ private function checkLinesAfterLastUse(File $phpcsFile, int $lastUsePointer): v
private function getRequiredLinesCountAfterLastUse(File $phpcsFile, array $tokens, int $lastUseEndPointer): int
{
$pointerAfterLastUse = TokenHelper::findNextEffective($phpcsFile, $lastUseEndPointer + 1);
assert(is_int($pointerAfterLastUse));
$isAtTheEndOfClass = $tokens[$pointerAfterLastUse]['code'] === T_CLOSE_CURLY_BRACKET;

if ($isAtTheEndOfClass) {
Expand Down
Loading