Conversation
added 2 commits
May 11, 2015 16:17
…een, e.g. from a parent directory of the Bower project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently we can only execute Preen from the root of a Bower package, i.e. where a file named
.bowerrcis present. In case this tool is run from outside the Bower repository (e.g. when incorporating into CI environments), it fails to find the Bower configuration.This pull request
Add an option 'cwd' to set the current working directory and execute Preen from e.g. a parent directory of the Bower project. This option now can be set to any Bower package and it doesn't matter anymore, from where Preen was executed.
I also decided to use
path.joininstead of string concatenation to avoid duplicate slashes in a a path (example as it occurred before:path/to/project//bower_components/…)Example