-
Notifications
You must be signed in to change notification settings - Fork 0
Mvp/toolbar #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mvp/toolbar #6
Conversation
…ntered Kopi action, favorites tab, Tailwind/theme cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transforms the app from an Expo starter template into a coffee shop-themed app with a custom navigation system. It introduces a new color palette centered around coffee tones, replaces default screens with five new tabs (Home, Favorites, Kopi, Orders, Me), and implements a custom tab bar featuring an elevated central "Kopi" button.
- Custom tab bar with elevated center button and rounded corners
- Coffee-themed color system using CSS variables and Tailwind configuration
- Five new placeholder screens with consistent styling using NativeWind
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tailwind.config.js | Extends content paths and adds custom coffee-themed color variables |
| global.css | Defines CSS variables for the coffee color palette |
| constants/theme.ts | Implements coffee-themed Palette and updates Colors for light/dark modes |
| components/ui/icon-symbol.tsx | Adds icon mappings for coffee, receipt, person, and star icons |
| app/(tabs)/orders.tsx | New Orders screen with placeholder content |
| app/(tabs)/me.tsx | New Me screen with placeholder content |
| app/(tabs)/kopi.tsx | New Kopi screen with placeholder content |
| app/(tabs)/index.tsx | Simplified Home screen replacing starter content |
| app/(tabs)/favorites.tsx | New Favorites screen with placeholder content |
| app/(tabs)/explore.tsx | Removed old Explore screen |
| app/(tabs)/_layout.tsx | Implements custom tab bar with KopiTabButton and themed styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </ThemedText> | ||
| </ThemedView> | ||
| </ParallaxScrollView> | ||
| <View className="flex-1 items-center justify-center bg-milk-coffee"> |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The order of flex utilities in className differs from other screens (using 'items-center justify-center' vs 'justify-center items-center'). For consistency with favorites.tsx, kopi.tsx, orders.tsx, and me.tsx, consider using 'justify-center items-center' order.
| <View className="flex-1 items-center justify-center bg-milk-coffee"> | |
| <View className="flex-1 justify-center items-center bg-milk-coffee"> |
| </ThemedView> | ||
| </ParallaxScrollView> | ||
| <View className="flex-1 items-center justify-center bg-milk-coffee"> | ||
| <Text className="text-xl font-semibold text-dark-coffee">Home Screen</Text> |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The font weight differs from other screens which use 'font-bold'. For consistency across all tab screens (favorites.tsx, kopi.tsx, orders.tsx, me.tsx), consider using 'font-bold' instead of 'font-semibold'.
| <Text className="text-xl font-semibold text-dark-coffee">Home Screen</Text> | |
| <Text className="text-xl font-bold text-dark-coffee">Home Screen</Text> |
| --color-light-coffee: #D7CCC8; | ||
| --color-medium-coffee: #8D6E63; | ||
| --color-grey: #BCAAA4; | ||
| } |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS variables are only defined for light mode in :root. Dark mode will still use these same colors. Consider adding a dark mode selector (e.g., .dark) with appropriate color values to match the dark theme colors defined in constants/theme.ts, or document that NativeWind colors will only work in light mode.
| } | |
| } | |
| .dark { | |
| --color-milk-coffee: #23211C; /* Example dark mode value, update as needed */ | |
| --color-dark-coffee: #D7CCC8; /* Example dark mode value, update as needed */ | |
| --color-light-coffee: #4A3B32; /* Example dark mode value, update as needed */ | |
| --color-medium-coffee: #6D4C41; /* Example dark mode value, update as needed */ | |
| --color-grey: #5D4037; /* Example dark mode value, update as needed */ | |
| } |
| shadowOpacity: isFocused ? 0.32 : 0.25, | ||
| }, | ||
| ]}> | ||
| <IconSymbol size={KOPI_ICON_SIZE} name="cup.and.saucer.fill" color="#FFFFFF" /> |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Hardcoded white color ('#FFFFFF') is used instead of the theme colors. Consider using Colors.white or Colors[theme].background for consistency with the theming system, making it easier to adjust if the design changes.
| <IconSymbol size={KOPI_ICON_SIZE} name="cup.and.saucer.fill" color="#FFFFFF" /> | |
| <IconSymbol size={KOPI_ICON_SIZE} name="cup.and.saucer.fill" color={Colors.white} /> |
| borderTopLeftRadius: BAR_RADIUS, | ||
| borderTopRightRadius: BAR_RADIUS, | ||
| borderTopWidth: 1, | ||
| borderWidth: 1, |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The borderWidth: 1 creates a border on all sides of the tab bar, but borderTopWidth: 1 is already set on line 167. This creates a double border on the top edge (2px total). Consider removing either borderWidth or borderTopWidth to avoid the redundant top border.
| borderWidth: 1, |
This pull request introduces a major redesign of the app's tab navigation and theming, moving from the default Expo template to a custom "coffee shop" theme. It replaces the starter content with new screens and navigation structure, implements a custom tab bar with a central "Kopi" button, and updates the color palette and icon set to match the new branding. Additionally, it documents the tech stack and configuration in a new
AGENTS.mdfile.Navigation & Screens
app/(tabs)/index.tsx,app/(tabs)/favorites.tsx,app/(tabs)/kopi.tsx,app/(tabs)/orders.tsx,app/(tabs)/me.tsx) [1] [2] [3] [4] [5]app/(tabs)/explore.tsx,app/(tabs)/index.tsx) [1] [2]Custom Tab Bar & Icons
_layout.tsxwith a prominent, elevated central "Kopi" button, custom icons, rounded corners, and themed colors. Uses a newKopiTabButtoncomponent for the center tab. (app/(tabs)/_layout.tsx)icon-symbol.tsxto include new icons for the coffee theme (e.g., coffee cup, receipt, star, person).icon-symbol.tsx.Theming & Styling
constants/theme.ts,global.css) [1] [2]global.css.Documentation
AGENTS.mdto document the project's runtime, navigation, styling, animation, state management, tooling, and platform configuration.