Conversation
|
I'm generally against this in the CI because examples should include larger examples with possibly longer runtimes and might (now or in the future) butcher the test runtime |
|
There's a script in the examples folder to run them and report any exceptions. |
|
yeah the CI on this PR hit the maximum 6 hours for a single job (you can have longer workflows, they just have to consist of sequential jobs <6h I believe). Even if we get the examples down to 6 hours it's not an option for the push-triggered or nightly runs. |
That's fair, we can take it out of the CI tests. Or, perhaps better, just blacklist the example we want to skip. I think we do something like that already for tests which are marked very slow? As a side note, I think we should really aim for examples with < 1min runtime. Even for some self-consistent examples, we should just increase the tolerance such that it only run 2 or 3 iterations - it's only about demonstrating the concept, not to give useful results. |
I didn't see that! To be honest, I don't think it should be there. It's not very useful for a user, it's more like a test - and if it's a test it should be in the test directory and use pytest syntax, like all other tests. |
I think we currently don't test that all the examples run without exception?
This adds tests for all example files.