Open
Conversation
1. Dockerfile — Upgraded for Ruby 3.3.10
- Base image changed from ruby:1.9.3 → ruby:3.3.10
- Removed Qt5/webkit packages and PhantomJS installation (both
deprecated)
- Added chromium and chromium-driver to match what CI uses
- Set CHROME_BIN=/usr/bin/chromium env var
- Consolidated apt-get into a single layer with cleanup
2. Removed PhantomJS and switched to using chromium for tests
3. Dependencies - Updated all to latest versions
4. Added rubocop, rubocop-rspec, rubocop-capybara and configuration
- Fixed issues using auto-correct
- Updated rubocop-todo.yml
5. `lib/billy/proxy_connection.rb` — Fixed frozen string literal bug
Fix for using headless chrome within ci (container environment) to avoid memory issues
Removed Aparition since it's not maintained anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Upgrade for supporting ruby 3.3.10
What story is associated with this PR? TBD
What kind of change does this PR introduce? Upgrade for ruby 3.3.10
Summary
lib/billy/proxy_connection.rb— Fixed frozen string literal bugHow can the reviewer see this work locally? N/A
Screenshots
Test Coverage
Documentation
See Repository Wiki Tab
Deployment
Does this PR introduce a breaking change? No
Are there special deployment instructions? No
Security Impact
For assistance, see this wiki page.