Merged
Conversation
gouravjawale28
requested review from
imsinu9,
indrajitmb,
sgyyz and
tarun-mahajan-mbo
sgyyz
reviewed
Jan 22, 2026
sgyyz
left a comment
sgyyz
left a comment
There was a problem hiding this comment.
left one comment about the code checkout, we can use the standard action for it
| rm phantomjs.tar.bz2 | ||
| phantomjs --version || echo "PhantomJS installed" | ||
|
|
||
| - name: Checkout |
There was a problem hiding this comment.
oh, is it possible to use the official action actions/checkout to checkout the code: https://github.com/actions/checkout
Author
There was a problem hiding this comment.
Thanks @sgyyz , I have modified the checkout section now.
sgyyz
approved these changes
Jan 22, 2026
sgyyz
left a comment
sgyyz
left a comment
There was a problem hiding this comment.
LGTM, but it's better to have another 👁️ to review the test changes.
darkthirst
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What story is associated with this PR?
[AB#1487427]
What kind of change does this PR introduce?
Sets up CI on Github Actions for Puffing-billy.
Summary
https://github.com/BookerSoftwareInc/puffing-billy/actions
Documentation
Github Actions Setup
https://github.com/ruby/setup-ruby