Skip to content

Adgudime/apex sac #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdityaGudimella wants to merge 3 commits into
base: releases/0.8.5
Choose a base branch
from
Open

Adgudime/apex sac #32

AdityaGudimella wants to merge 3 commits into from

Conversation

@AdityaGudimella
Copy link

@AdityaGudimella AdityaGudimella commented Aug 24, 2020 •
edited
Loading

Why are these changes needed?

Fixed a bug in action shape calculation
Tuned hyperparameters for tests. Pendulum now converges successfully.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AdityaGudimella AdityaGudimella self-assigned this Aug 24, 2020
@AdityaGudimella AdityaGudimella requested a review from Edilmo August 24, 2020 19:58
Edilmo
Edilmo reviewed Aug 24, 2020
View reviewed changes
Copy link

@Edilmo Edilmo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but we have to change the target branch to releases/0.8.6
I will approve after that.

@AdityaGudimella AdityaGudimella changed the base branch from releases/0.8.5 to releases/0.8.6 August 24, 2020 21:06
@AdityaGudimella AdityaGudimella changed the base branch from releases/0.8.6 to releases/0.8.5 August 24, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Edilmo Edilmo Edilmo left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@AdityaGudimella AdityaGudimella

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdityaGudimella @Edilmo