Improve user namespace detection #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu, the usage of mount namespaces is apparently restricted in unprivileged user namespaces. In particular, if /proc/sys/kernel/apparmor_restrict_unprivileged_userns_complain is enabled, the clone() or unshare() call succeeds but the following mount() call to make the mount namespace private is rejected.
Make sure the namespace-sandbox binary is up-to-date before any of the test runs. Some of the blackbox tests call it directly and they could accidentally call an outdated version.
Add the Ubuntu procfs knob and actually test for the current value to give a more precise hint of what is going on.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 89.38% 89.26% -0.12%
==========================================
Files 50 50
Lines 16404 16417 +13
==========================================
- Hits 14662 14655 -7
- Misses 1742 1762 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Ubuntu restrictions...