Parallel strip class #280
Merged
Parallel strip class #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with process substation is that it effectively disables the effect of "set -e" for the substituted command. Use a more straight forward pipe instead
While xargs can spawn multiple processes in parallel, it does not integrate into the make job server protocol. This can easily overload the system. Roll our own small helper that is just enough to understand the job server and call some strip commands.
Prepare to be used as a tool in the strip class. Using it there requires that the tool is available everywhere.
If possible, process the files in parallel.
This has the nice property that, without any argument, stripAll will work on the current directory.
Instead of dropping requests to strip object files in stripBinary(), exclude them already during fine. This saves some useless shell invocations.
Now that stripping works in parallel, pass all involved directories at once.
These tools are only used internally by the build steps. Their exact version should not make a difference. Improve the artifact cache hit rate by making these tools weak.
Passing the current directory as "." is not necessary because this is the default.
Contributor
|
This is so great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
pxargs(parallel xargs) helper that obeys the make job server protocol and use it in the strip class to parallelise all the objcopy calls. We may use the tool later for more parallelism in other recipes as well.