Move require statements to the beginning#6
Open
Kinrany wants to merge 9 commits intoBluespess:masterfrom
Open
Conversation
monster860
requested changes
Mar 27, 2019
Author
|
Wait, |
Member
|
yeah that too |
Author
|
I checked the cyclic dependencies with madge, there shouldn't be any now. Well, other than those fixed by |
Author
|
Ahh, no, just using |
monster860
requested changes
Mar 28, 2019
Author
|
Should work now. How do you test this stuff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all the require statements that don't have to be dynamic to the beginning of the files