Skip to content

Change invalid hyphen numbers to > 1 instead of != 1 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NhatHuyNguyen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change invalid hyphen numbers to > 1 instead of != 1 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/kotlin/com/illusion/checkfirm/common/util/Tools.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ object Tools {
}

private fun isValidModel(model: String): Boolean {
// Hyphen이 하나만 있는지 확인
if (model.count { it == '-' } != 1) {
// Hyphen > 1 is invalid. Japanese KDDI models have no hyphen
if (model.count { it == '-' } > 1) {
return false
}

Expand Down