-
Notifications
You must be signed in to change notification settings - Fork 2
Write prebuffered data #18
base: master
Are you sure you want to change the base?
Conversation
- Added integration test - Small variable namewqwq refactoring
| size_t buffered_data_size, | ||
| uint32_t steps_to_write) { | ||
| if (sonata_report.is_empty()) { | ||
| return -3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor] You could also use standard errno values:
https://man7.org/linux/man-pages/man3/errno.3.html
sergiorg-hpc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just minor comments here and there, mostly out of curiosity.
|
As this is draft and needs to be discussed in the context of coreneuron + gpu integration aspects, I will review this after coreneuron discussion. |
Create a new API call to provide a writting mechanism given a prebuffered data and the number of steps in the buffer.