Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@jorblancoa
Copy link
Collaborator

Create a new API call to provide a writting mechanism given a prebuffered data and the number of steps in the buffer.

size_t buffered_data_size,
uint32_t steps_to_write) {
if (sonata_report.is_empty()) {
return -3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] You could also use standard errno values:
https://man7.org/linux/man-pages/man3/errno.3.html

Copy link
Collaborator

@sergiorg-hpc sergiorg-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor comments here and there, mostly out of curiosity.

@pramodk
Copy link
Contributor

pramodk commented Oct 12, 2021

As this is draft and needs to be discussed in the context of coreneuron + gpu integration aspects, I will review this after coreneuron discussion.
@jorblancoa : I think it will be helpful to have a brief discussion / provide summary of how existing reporting works (implementation aspects) in coreneuron+libsonatareport execution. This will give a better clarity to @olupton @iomaganaris @sergiorg-hpc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants