[WIP] Address feedback from review on canvas origami implementation #7511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
- Remove duplicate SVG files from artwork directory - Add Enhance comment in BookThumbNailer.cs about unnecessary image processing - Refactor Book.cs comment and logic for better clarity on placeholder handling - Fix BloomServer.cs to send 404 response for placeholder requests - Update comment in BloomPubMaker.cs for clarity on placeholder handling - Update comment in CanvasElementManager.ts to include placeholder case - Mark CutImage string as obsolete in xlf file - Add translate="no" to Canvas xlf entry - Fix CSS to allow cropping non-placeholder background images - Fix bloomImages.ts to handle URLs with query parameters and rename parameter Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is