Skip to content

Conversation

Copy link

Copilot AI commented Nov 21, 2025

The MakeManifest method expects a relative path (folder + filename), but was receiving a full absolute path after recent changes, breaking cover image matching in EPUB generation.

Changes

  • Fixed MakeManifest call at line 555 to pass kImagesFolder + "/" + Path.GetFileName(epubThumbnailImagePath) instead of the full epubThumbnailImagePath
  • Ensures cover image matching works correctly (relies on Path.GetFileNameWithoutExtension at line 749 and item comparison at line 823)
// Before: passed full path
MakeManifest(thumbnailFileExists ? epubThumbnailImagePath : null);

// After: passes relative path
MakeManifest(thumbnailFileExists ? kImagesFolder + "/" + Path.GetFileName(epubThumbnailImagePath) : null);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.


This change is Reviewable

@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Address feedback from PR review on canvas origami element Fix EpubMaker.MakeManifest to use relative path instead of full path Nov 21, 2025
Copilot AI requested a review from nabalone November 21, 2025 17:04
@andrew-polk andrew-polk deleted the copilot/sub-pr-7504 branch November 22, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants