Skip to content

Corrected JSHint errors and fixed code alignment#38

Open
MichaelF2 wants to merge 2 commits intoBlitzen:masterfrom
MichaelF2:master
Open

Corrected JSHint errors and fixed code alignment#38
MichaelF2 wants to merge 2 commits intoBlitzen:masterfrom
MichaelF2:master

Conversation

@MichaelF2
Copy link
Copy Markdown
Contributor

This is the version we are using in our Angular app. Made some minor changes such as triple equality checks, removed duplicate var definitions, etc. The bottom half of the code had misaligned spacing, so this was corrected as well. The diff is somewhat difficult to read in the online editor. The changes are more obvious in WinMerge.

This is the version we are using in our Angular app.  Made some minor changes such as triple equality checks, removed duplicate var definitions, etc.  The bottom half of the code had misaligned spacing, so this was corrected as well.
Corrected JSHint errors and fixed code alignment
@MichaelF2
Copy link
Copy Markdown
Contributor Author

Full list of modifications in pull request:

Removed unused variables: isDefined, forEach
Fixed duplicate variable defintions: areSimilar, differences, eq, returnEq, tooSim
Added missing semicolon after returnEq assignment
Added hasOwnProperty checks to "for ... in" loops
Fixed scoping issues for variables: areSimilar, differences, parsedUnequalVariable, tooSim
Changed all equality checks from == to ===
Changed all inequality checks from != to !==
Fixed whitespace issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant