Skip to content

Multi-expansion MMC5 + FDS conflict fix #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GreatGlobox wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Multi-expansion MMC5 + FDS conflict fix #423

GreatGlobox wants to merge 19 commits into from

Conversation

@GreatGlobox
Copy link
Contributor

@GreatGlobox GreatGlobox commented Nov 20, 2025 •
edited
Loading

There was an offset issue regarding the extra FDS envelope added for multi-wave some time ago. It was conflicting with MMC5 square 1.

Other fixes:

  • Pattern merging fix
  • Song loop note release / duration fix
  • Sequencer duplicate / instantiate bug on single pattern selection
  • Fix for illegal characters in FS file dialogs
  • Fixed crash regarding broken text files without a valid song (niche, but why not)
  • Updated Silver Surfer demo song
  • Fixed ghost notes so they no longer display attack
  • Fixed text import possibly having out of range envelope values

@GreatGlobox
Multi-expansion MMC5 + FDS conflict fix
c440c8e 
There was an offset issue regarding the extra FDS envelope added for multi-wave some time ago. It was conflicting with MMC5 square 1.
@GreatGlobox
Multiple fixes
89843ad
@GreatGlobox
Merge branch 'BleuBleu:master' into master
9e71167
@GreatGlobox
No need to copy if patterns have not moved
071bbf9
@GreatGlobox
Merge branch 'master' of https://github.com/GreatGlobox/FamiStudio
f4c5f67
@GreatGlobox
Select if selection is clear
3262bf0
@GreatGlobox
Strip illegal characters on save for FS dialog
f64d3de
@GreatGlobox
Oops. Forgot about path separators
955fdce
@GreatGlobox
Prevent crash with broken text file
ccb3c2f
@GreatGlobox
Create blank song instead
d2134d5 
Very niche crash that should never happen from the output of the program itself anyway.
@GreatGlobox
More sensible workaround for sequencer
c4735b6
@GreatGlobox
Silver Surfer long slide improvement
21adea1 
The slides sounded off, the lower one reached its target far too early. Made adjustments based on the real song while still just using slide notes and nothing fancy.
@GreatGlobox
Another update
0ad806a
@GreatGlobox
Update assembly demos for Silver Surfer
64dc6de
@GreatGlobox
Remove useless extra instrument
8c91732
@GreatGlobox
Sequencer instantiate fix (again)
adb2047
@GreatGlobox
Simpler text fix + ghost note attack fix
d837572 
Simply just return null for an empty project if text files are bogus. Also no longer render attack on ghost notes.
@GreatGlobox
Clamp text import envelopes
1c38d27 
Garbage text files could import envelopes out of range, causing assert errors and undesired effects in the program.
@GreatGlobox
Add log for FS text file clamping
783be04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GreatGlobox