Implement a better options menu by Polarite · Pull Request #42 · Bixilon/Minosoft

Polarite · 2025-12-09T11:22:10Z

Currently doesnt have a menu for resource packs.
Theres an issue with updating the clouds when you change settings, I dont think its an issue on options menu side.
Its missing some options that would be nice to have, open for suggestions on that.
Chat settings should have a proper textbox implementation for setting width...

Bixilon

Just the initial code review, have not looked deeper inside nor tested it.

...in/java/de/bixilon/minosoft/gui/rendering/gui/elements/input/button/AbstractButtonElement.kt

Bixilon · 2025-12-09T17:04:59Z

...in/java/de/bixilon/minosoft/gui/rendering/gui/elements/input/button/AbstractButtonElement.kt


    private companion object {
-        val CLICK_SOUND = minecraft("ui.button.click")
+        val CLICK_SOUND = "minecraft:ui.button.click".toResourceLocation()


val CLICK_SOUND = minecraft("ui.button.click")

I believe theres some issues with sounds, I couldnt get them to work, no ideas why...

src/main/java/de/bixilon/minosoft/gui/rendering/gui/elements/input/slider/SliderElement.kt

...main/java/de/bixilon/minosoft/gui/rendering/gui/gui/screen/menu/options/CloudSettingsMenu.kt

Bixilon · 2025-12-09T17:10:37Z

src/main/java/de/bixilon/minosoft/gui/rendering/gui/gui/screen/menu/options/GUISettingsMenu.kt

+        updateDisabledStates()
+    }
+
+    private fun updateDisabledStates() {


The profile provides delegates. You can easily observe it. Justs create a profile synced button (or so), that observes the profile and updates the button when that "event" is triggered. No need for polling.

src/main/java/de/bixilon/minosoft/gui/rendering/gui/gui/screen/menu/options/OptionsMenu.kt

src/main/java/de/bixilon/minosoft/gui/rendering/sky/clouds/CloudRenderer.kt

Polarite · 2025-12-09T19:59:34Z

Slider bars still are wonky, I will rewrite that.
Controls are still not working, I am unsure how can I make something that looks good with current UI and menus.
Do we... even support resource packs...
Please check if I have fixed them like you want, I kinda got confused at some points. Language settings is dirty but its as best as I could manage to make it...

Polarite · 2026-01-13T21:19:24Z

well that rebase fucking died on me.

…fullbright. Theres currently many issues but I taped it together and it kinda works(?) it currently has these problems: * Doesnt include all options * Cloud options when changed override "moving clouds" setting. * Sliders sometimes dont set to exact numbers D: * Slider system isnt exactly same as minecrafts, which I am not sure how to make work... It doesnt feel as smooth as minecrafts sliders... * The Chat width and height text boxes cant be changed, the boxes needs a special input block similar to... you guessed it! * The tooltips dont follow the cursor, I couldnt find out a way to implement it that isnt a taped together ugly tech. * Sliders are missing the grayed out textures, currently only making them slightly transparent, at least til I can bother to fix the "knob" texture being an actual knob :') * Settings tabs should probably be reorganized in a better manner, current organization feels a little all over the place. * Translation strings needs to be added, I gave up at some point :') * I dont have headphones with me... Does the master volume slider work?? * Graying out of buttons doesnt work after rebasing. * Hi, please dont be mean :) Update SliderElement.kt fixed the updated version of minosoft (graying out buttons is broken)

fixes to make it actually compile, damn it.

Slider bars still are wonky, I will rewrite that. Controls are still not working, I am unsure how can I make something that looks good with current UI and menus. Do we... even support resource packs lmao?

…t and mouse capturing for it.

my bad for using outdated file haha :')

…n can be fullfilled This excludes cases if a combination for "E+T+Y" exists and you press "E" to open the inventory, you can press Y+T+E on those cases so neither chat or inventory opens and you can use the combination for that... I think even vanilla minecraft bothered with their controls menu this much I swear...

…n case.

Bixilon

So (finally making a review):

All the possible languages are in code, that feels wrong. Can be move that to a json file in the assets? 371dc9a

I don't really care about the old UI system anymore, so I am kind of blindly accepting it.

From UI perspective:

feels weird that you can smoothly slide the biome radius like it was a decimal value.
scrolling in controls makes me change the hotbar slot

From code:

there is a lot of duplicated code or unused variables
please remove unnecessary comments

This style is not good:

    private val textFilteringButton: ButtonElement

...
        textFilteringButton = ButtonElement(guiRenderer, formatEnabled("menu.options.chat.text_filtering", chatProfile.textFiltering)) {
            chatProfile.textFiltering = !chatProfile.textFiltering
            textFilteringButton.textElement.text = formatEnabled("menu.options.chat.text_filtering", chatProfile.textFiltering)
        }
        this += textFilteringButton

This whole part can be squashed into

this += BooleanDelegateButton(guiRenderer, "menu.options.chat.text_filtering".i18n(), delegate = chatProfile::textFiltering)

(and it handles translation, getting, setting, observing and formatting)

I added those changes, see 0e7c250

Translation are messed:

    protected fun translate(key: String): String {
        return IntegratedLanguage.LANGUAGE.forceTranslate(key.i18n().translationKey).message
    }

The text formatting does that automatically, no need for anything. just use the translation key as text (in a base component).

I don't really like that the in game ui is responsible for most settings, why not in eros?

This is a really big first PR, it might make sense to split this.

Is this AI coded? I can not accept pure AI contributions.

Bixilon · 2026-01-24T15:18:18Z

...n/java/de/bixilon/minosoft/gui/rendering/gui/gui/screen/menu/options/ControlsSettingsMenu.kt

+        private val SCROLLBAR_TRACK_COLOR = RGBAColor(40, 40, 40, 180)
+        private val SCROLLBAR_THUMB_COLOR = RGBAColor(120, 120, 120, 220)
+
+        val CATEGORIZED_KEYBINDINGS: Map<String, Map<ResourceLocation, KeyBinding>> = linkedMapOf(


why are all keybindings duplicated here?

Bixilon · 2026-01-24T15:19:22Z

src/main/java/de/bixilon/minosoft/gui/rendering/gui/input/MouseCapturing.kt

+import de.bixilon.minosoft.gui.rendering.gui.input.mouse.MouseButtons
+
+/**
+ * Interface for GUI elements that can capture mouse input.


I really don't want such comments, everything should be self explaining .

Bixilon · 2026-01-24T15:19:44Z

src/main/java/de/bixilon/minosoft/gui/rendering/gui/input/MouseCapturing.kt

+ * This file exists purely for sliders in menus to be able to capture mouse outside their bounds. 
+ * Could have more uses in future...
+ */
+interface MouseCapturing {


Why just relativeX? Why not relativeY? Why relative at all and not absolute?

Bixilon · 2026-01-24T15:23:47Z

src/main/java/de/bixilon/minosoft/gui/rendering/input/key/manager/binding/BindingsManager.kt

    }

    fun onKey(code: KeyCodes, pressed: Boolean, handler: InputHandler?, time: ValueTimeMark) {
+        // Find all satisfied bindings that use this key and track their key counts


Not sure if thats good. The current behavior is depending on the order of registration. Shouldn't all of them just be triggered? But that breaks (e.g. Q and CTRL + Q). The whole keysystem feels somehow not great anymore.

This function needs refactoring, feels really long and clumsy now.

the problem with the current system was if you assign Shift+Q as a key for walking forward character drops item in inventory while achieving shift+q key as well, and if the combination keys are used for movement, and stopping pressing the keys isnt detected

I believe controlling in general needs a rewrite before properly supporting combination keystrokes...

Bixilon · 2026-01-24T15:24:49Z

...n/java/de/bixilon/minosoft/gui/rendering/gui/gui/screen/menu/options/ControlsSettingsMenu.kt

+             * Creates a unique signature for a key binding based on its key codes.
+             * Used for duplicate detection.
+             */
+            fun getBindingSignature(binding: KeyBinding): String {


Why is this a string? Why not just the set (you can use EnumSets from kutil)

Bixilon requested changes Dec 9, 2025

View reviewed changes

Polarite marked this pull request as draft January 13, 2026 21:22

Polarite added 5 commits January 14, 2026 00:23

Update AbstractButtonElement.kt

6ea4d88

fixes to make it actually compile, damn it.

Simplify settings menus using Menu base class and fix cloud fullbright

dbfd760

Added Language Settings, done most of the requested fixes.

371dc9a

Slider bars still are wonky, I will rewrite that. Controls are still not working, I am unsure how can I make something that looks good with current UI and menus. Do we... even support resource packs lmao?

Fixes to cloud settings, Added controls settings, fixed slider elemen…

f9f3be2

…t and mouse capturing for it.

Polarite force-pushed the mistress branch from 4db19bb to f9f3be2 Compare January 13, 2026 21:24

Update copyright year

6053339

my bad for using outdated file haha :')

Polarite requested a review from Bixilon January 13, 2026 21:26

Polarite and others added 7 commits January 15, 2026 21:46

Make duplicate keybinds in controls change to red.

b41a86f

Fix bindingmanager getting confused when combination keys are used.

e2b3ad2

fix combination key holding in keyactionfilter.

e6ed0a7

Implemented a textbox element and a search system for controls just i…

165e47e

…n case.

language: add integrated language as fallback

b40e69d

option menu: button delegate

0e7c250

Bixilon reviewed Jan 24, 2026

View reviewed changes

Conversation

Polarite commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bixilon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Polarite commented Dec 9, 2025

Uh oh!

Polarite commented Jan 13, 2026

Uh oh!

Bixilon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Polarite commented Dec 9, 2025 •

edited

Loading