Skip to content

Provide class Filter toSimple with polyfill #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tchalvak wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Provide class Filter toSimple with polyfill #1758

tchalvak wants to merge 3 commits into from

Conversation

@tchalvak
Copy link
Member

@tchalvak tchalvak commented May 31, 2024 •
edited
Loading

For use with filtering down to low simple alphanumerics,

getting rid of ugly html-likes, and similar.

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak
Provide filter to simple polyfill
ae47891 
For use with filtering down to low simple alphanumerics,

getting rid of ugly html-likes, and similar.
@tchalvak tchalvak changed the title Provide filter to simple polyfill Provide class Filter toSimple with polyfill May 31, 2024
@deepsource-autofix
style: format code with PHP CS Fixer
04fbaf7 
This commit fixes the style issues introduced in ae47891 according to the output
from PHP CS Fixer.

Details: #1758
@cypress
Copy link

cypress bot commented May 31, 2024 •
edited
Loading

NinjaWars Functional Testing    Run #659

Run Properties:  status check passed Passed #659  •  git commit b937d9ca78 ℹ️: Merge 439914e78587551d1a647b799e1da48b88aea074 into e9df248fbb75f4149ec40612ccae...
Project NinjaWars Functional Testing
Branch Review feat/filter
Run status status check passed Passed #659
Run duration 01m 42s
Commit git commit b937d9ca78 ℹ️: Merge 439914e78587551d1a647b799e1da48b88aea074 into e9df248fbb75f4149ec40612ccae...
Committer Coco R
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@tchalvak tchalvak enabled auto-merge May 31, 2024 22:51
@tchalvak
Copy link
Member Author

tchalvak commented Jun 1, 2024

Need to pull the test updates over as well.

@tchalvak tchalvak added the wip label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tchalvak