Globally defined vee-validate rules + Use i18n to translate rule errors#79
Open
marwins wants to merge 1 commit intoBitBagCommerce:mainfrom
Open
Globally defined vee-validate rules + Use i18n to translate rule errors#79marwins wants to merge 1 commit intoBitBagCommerce:mainfrom
marwins wants to merge 1 commit intoBitBagCommerce:mainfrom
Conversation
dead-playmod
requested changes
Jun 16, 2023
Contributor
dead-playmod
left a comment
There was a problem hiding this comment.
Hey @marwins, this is a great idea, and after my quick look through everything seems fine, except that field names in login form (and I think in some other places too) aren't parsed correctly.
It seems to be caused by missing name prop on <ValidationProvider>, if you could fix that and resolve conflicts we could merge this PR if there isn't any other issues.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Globally defined vee-validate rules + Use i18n to translate rule errors
Description
Create a nuxt plugin to globally configure vee-validate.
Configuration include global rule definition + defaultMessage function to translate validation message via i18n
Related Issue
#78
Motivation and Context
The project doesn't translate form validation message
How Has This Been Tested?
I tested the code on my own project and report development to SyliusVueStorefront2Frontend fork.
Types of changes
Checklist: