Fix rate limiter IP spoofing and memory growth#13
Open
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Open
Fix rate limiter IP spoofing and memory growth#13BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
1. Fix X-Forwarded-For trust
The rate limiter directly trusted the
X-Forwarded-Forheader for client IP identification. Any client can spoof this header to bypass rate limiting entirely by sending a different IP on each request.Now defaults to
request.client.host(the actual TCP connection IP). Only usesX-Forwarded-ForifTRUST_PROXY=trueis explicitly set - which should only be enabled when running behind a known reverse proxy.Same fix applied to
backend/utils/__init__.pyandbackend/utils/request.pywhich had the same pattern.2. Stale entry cleanup
The in-memory rate limiter dicts grew without bound since entries were never removed. Added periodic cleanup that purges entries older than the rate limit window.
No new dependencies. Backward compatible (defaults to safer behavior).