Code quality: pin dependencies, sanitize SQL, refresh tests, remove dead code#12
Open
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Open
Code quality: pin dependencies, sanitize SQL, refresh tests, remove dead code#12BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Conversation
…, remove dead code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
1. Pin unpinned dependency
openinference-instrumentation-openai-agentswas completely unpinned inrequirements.txt. Pinned to0.1.14. An unpinned dependency means any upstream publish (including compromised ones) flows directly into builds.2. SQL wildcard sanitization
Added
escape_sql_wildcards()torag_service.pyto escape%and_characters in user-provided search terms before they hitilikequeries. Prevents users from crafting wildcard patterns that bypass intended filtering.3. Refreshed test file
Replaced the stale
test_backend.py(referenced old APIs and required local embeddings) with a minimal smoke test that verifies the FastAPI app imports and initializes correctly. This at least catches import-time errors and missing dependencies.4. Removed dead code
backend/actions/bundle.py(legacy embedding bundler, no longer imported anywhere)backend/actions/embed.py(legacy embedder, no longer imported)Net reduction of ~170 lines. No behavior changes to the running application.