Fix frontend production deployment and health check port#11
Open
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Open
Fix frontend production deployment and health check port#11BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
BrandonS7 wants to merge 1 commit intoBirmingham-AI:mainfrom
Conversation
a5b1838 to
092bd69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
1. Frontend Dockerfile - production build
The current Dockerfile runs
npm run dev(Vite dev server) in production. This exposes source maps, hot module replacement, and dev tooling to the public internet.Replaced with a proper multi-stage build:
npm ci+npm run buildon Node 20 Alpinedist/via Nginx AlpineAdded
frontend/nginx.confwith SPA routing (try_filesfallback toindex.html) and long-lived cache headers for static assets.2. Health check port fix
The
docker-compose.ymlhealth check was probinglocalhost:8001but the backend listens on port8000. Fixed to match the actual application port.3. Compose cleanup
5174:5173to5174:8080(Nginx)Minimal changes, no backend modifications.