Fresh tracks were unable to be saved#169
Open
failure-to-thrive wants to merge 1 commit intoBioroboticsLab:masterfrom
Open
Fresh tracks were unable to be saved#169failure-to-thrive wants to merge 1 commit intoBioroboticsLab:masterfrom
failure-to-thrive wants to merge 1 commit intoBioroboticsLab:masterfrom
Conversation
Contributor
|
Well, yes, it was there intentionally. Technically a trajectory needs at least two points to be considdered a trajectory (per definition). Maybe there are usecases for writing a trajectory consisting of a single point, so replacing <=1 with <1 seems reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted code induced #156. Of course,
getMaxLinecount()returns only 1 when a tracking is not performed yet. I have no idea why that code was there, but it looks to be there intentionaly. So if I've missed something, just dismiss this PR.