Open
Conversation
Collaborator
Author
|
Code runs! Results have to be checked |
MistreanuIonutCosmin
requested review from
andychenbruce
and removed request for
Alexander-Aghili
| # Save final state | ||
| state = simulation.context.getState( | ||
| getPositions=True, | ||
| getVelocities=True, |
Collaborator
There was a problem hiding this comment.
Are you sure you need velocities? It would increase the filesize by probably about double and I'm not sure anything uses them.
Collaborator
There was a problem hiding this comment.
Its only at the end after the segment completed the run so I don't think its a huge bottleneck. Happy to check the profile though if you are concerned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boilerplate code. not running yet