Claude/roadmap feature branches 01 m22wg q ff vy gz ya p sh w1 m9k #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,9 +5,16 @@ import { | |
| Info, | ||
| X, | ||
| Github, | ||
| Share2, | ||
| Check, | ||
| Images, | ||
| } from 'lucide-react'; | ||
| import { Settings } from './Settings'; | ||
| import { ImageGallery } from './ImageGallery'; | ||
| import { isGeminiConfigured } from '../services/geminiService'; | ||
| import { getGalleryCount } from '../services/galleryService'; | ||
| import { useChronoscope } from '../context/ChronoscopeContext'; | ||
| import { copyShareableUrl } from '../utils/urlManager'; | ||
|
|
||
| interface HeaderProps { | ||
| onApiKeyChange?: () => void; | ||
|
|
@@ -17,7 +24,20 @@ export function Header({ onApiKeyChange }: HeaderProps) { | |
| const [currentTime, setCurrentTime] = useState(new Date()); | ||
| const [showInfo, setShowInfo] = useState(false); | ||
| const [showSettings, setShowSettings] = useState(false); | ||
| const [showGallery, setShowGallery] = useState(false); | ||
| const [apiConfigured, setApiConfigured] = useState(isGeminiConfigured()); | ||
| const [galleryCount, setGalleryCount] = useState(0); | ||
| const [copied, setCopied] = useState(false); | ||
| const { state } = useChronoscope(); | ||
|
|
||
| const handleShare = async () => { | ||
| if (!state.currentScene) return; | ||
| const success = await copyShareableUrl(state.currentScene.coordinates); | ||
| if (success) { | ||
| setCopied(true); | ||
| setTimeout(() => setCopied(false), 2000); | ||
| } | ||
| }; | ||
|
|
||
| // Update real-world time every second | ||
| useEffect(() => { | ||
|
|
@@ -27,6 +47,19 @@ export function Header({ onApiKeyChange }: HeaderProps) { | |
| return () => clearInterval(timer); | ||
| }, []); | ||
|
|
||
| // Load gallery count on mount and listen for updates | ||
| useEffect(() => { | ||
| const loadCount = async () => { | ||
| const count = await getGalleryCount(); | ||
| setGalleryCount(count); | ||
| }; | ||
| loadCount(); | ||
|
|
||
| // Listen for gallery update events | ||
| window.addEventListener('galleryUpdated', loadCount); | ||
| return () => window.removeEventListener('galleryUpdated', loadCount); | ||
| }, []); | ||
|
|
||
| return ( | ||
| <> | ||
| <header className="bg-chrono-panel/90 backdrop-blur-sm border-b border-chrono-border px-4 py-3"> | ||
|
|
@@ -75,6 +108,32 @@ export function Header({ onApiKeyChange }: HeaderProps) { | |
|
|
||
| {/* Actions */} | ||
| <div className="flex items-center gap-2"> | ||
| <button | ||
| onClick={handleShare} | ||
| disabled={!state.currentScene} | ||
| className={`p-2 transition-colors ${ | ||
| state.currentScene | ||
| ? copied | ||
| ? 'text-chrono-green' | ||
| : 'text-chrono-text-dim hover:text-chrono-blue' | ||
| : 'text-chrono-text-dim/30 cursor-not-allowed' | ||
| }`} | ||
| title={copied ? 'Link copied!' : state.currentScene ? 'Share coordinates' : 'Render a scene first'} | ||
| > | ||
| {copied ? <Check className="w-5 h-5" /> : <Share2 className="w-5 h-5" />} | ||
| </button> | ||
| <button | ||
| onClick={() => setShowGallery(true)} | ||
| className="relative p-2 text-chrono-text-dim hover:text-chrono-green transition-colors" | ||
| title="Image Gallery" | ||
| > | ||
| <Images className="w-5 h-5" /> | ||
| {galleryCount > 0 && ( | ||
| <span className="absolute -top-0.5 -right-0.5 min-w-[1rem] h-4 px-1 flex items-center justify-center text-[10px] font-mono rounded-full bg-chrono-green text-chrono-black"> | ||
| {galleryCount > 99 ? '99+' : galleryCount} | ||
| </span> | ||
| )} | ||
| </button> | ||
| <button | ||
| onClick={() => setShowInfo(true)} | ||
| className="p-2 text-chrono-text-dim hover:text-chrono-blue transition-colors" | ||
|
|
@@ -115,6 +174,16 @@ export function Header({ onApiKeyChange }: HeaderProps) { | |
| }} | ||
| /> | ||
|
|
||
| {/* Image Gallery Modal */} | ||
| <ImageGallery | ||
| isOpen={showGallery} | ||
| onClose={() => { | ||
| setShowGallery(false); | ||
| // Refresh count when closing | ||
| getGalleryCount().then(setGalleryCount); | ||
| }} | ||
| /> | ||
|
|
||
| {/* Info Modal */} | ||
| {showInfo && ( | ||
| <div className="fixed inset-0 z-50 flex items-center justify-center p-4 bg-chrono-black/80 backdrop-blur-sm"> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
setTimeoutto delayrenderSceneis an anti-pattern in React and can lead to bugs. TherenderScenefunction is closed over from the initial render and will not have the updated coordinates fromsetCoordinates, which can cause it to work with stale state. This is a race condition that might appear to work due to timing luck but is not reliable.A more idiomatic and robust approach is to use separate
useEffecthooks to first set the state, and then react to that state change to perform the render. This ensures you are always working with the latest state.Consider replacing this
useEffectwith the following two hooks:This change also allows you to remove the
eslint-disablecomment, as dependencies are correctly managed.